Legg til displayAttribute til SearchableDropdown og AccountSelector #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it possible to override what is displayed in the SearchableDropdown input previous default was the first attribute in the searchAttribute prop. The same should be the case with this change
alexander-svendsen
force-pushed
the
develop
branch
from
02ca829 to
901ec32
Compare
dagfrode
reviewed
Feb 28, 2025
packages/ffe-account-selector-react/src/account-selector/AccountSelector.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ffe-account-selector-react/src/account-selector/AccountSelector.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ffe-account-selector-react/src/account-selector/AccountSelector.stories.tsx
Outdated
Show resolved
Hide resolved
dagfrode
previously approved these changes
Feb 28, 2025
makes it possible to override what is displayed in the AccountSelector input. So you can have a new custom attribute in the input, example a new attribute that contains: account_name - account_number previous default was the first attribute in the searchAttribute prop. The same should be the case with this change. Needed to add the displayAttribute to the searchAttributes passed to the SearchableDropdown, so the user don't see a message about 0 hits when changing the input.
alexander-svendsen
force-pushed
the
develop
branch
from
901ec32 to
c1baf20
Compare
dagfrode
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Legger til en prop kalt
displayAttributeiSearchableDropdownogAccountSelector.Denne propen lar deg overstyre hvilket element i objektene sendt inn (
Item/T extends Account) som er brukt til visning i input elementet.Defaulten før var det første elementet i
searchAttributes(ble navn), det er fortsatt samme defaultDisse endringene burde ikke har noe å si for eksisterende bruk, kun for nye.
Viktig å få med seg endringen i
AccountSelectorpå søk. Jeg ble nød til å legge til den nyedisplayAttributepropen tilsearchAttributessendt videre tilSearchableDropdownkomponenten, for å ikke få "Ingen konto funnet" når man prøver å endre inputen etter det er valgt et element.Skjermbilde på
SearchableDropdown:Skjermbilde på
AccountSelector:Lagt inn ny story i StoryBook-en til
AccountSelectorfor å vise bruk.Også lagt til nye tester på begge komponenter som verifiserer at dette funker.
Motivasjon og kontekst
Vi i team sparing ønsker å vise mer enn bare konto navn på Spareoversikt konto velgeren. Er flere brukere som har samme navn på flere kontoer. Vi ønsker at det skal vises slik i
AccountSelector-en: "Kontonavn - Kontonummer"Se skjermbilde
Men vi ønsker ikke å bytte navn på kontoene i nedtrekksmenyen.
Så dette viser seg å være vanskelig med dagens løsning.
Disse endringene gjør det mulig å få til det som er ønsket
Testing
Lagt til jest tester
Lagt inn nye stories i StoryBook-en som viser bruk og eksempler